Skip to content

Commit

Permalink
[MBL-624] XCode 14.3 Update (#1820)
Browse files Browse the repository at this point in the history
* project building on xcode 14.3

Kingfisher also updated to support swift 5.8

* running screenshot tests on a new xcode, simulator and macOS causes minor differences in some snapshots.

Again related to xcode version update/new simulator/macOS update system OS update. Reference post: pointfreeco/swift-snapshot-testing#450 (comment)

There are more..but this is a partial commit.

* discovery navigation header view recorded snapshots

* curated projects vc recorded snapshot tests

* discovery page view controller tests

* updated snapshot tests

* pledge payment methods

* circle ci config update

* applyiing recommended build settings

* turned enable_module_verifier from recommended settings because it prevented Stripe framework from linking.

Xcode 14.3 includes a new module verifier that generates diagnostics for issues in a framework’s modules. (97345247)

* circleci doesn't support xcode 14.3 yet, its only a few days old.

* pre-install required simulator on ci

* trying to correct the cmd to install simulator

* correction

* correction

* correction

* update runtime trying to install simulator

* makefile should also use iOS 15.5

* updated xcode version to 14.3.0 - it is supported according to documentation

* manually setting ruby version and mac os

* newline correction

* going back to xcode 14.2

* setting ruby version in build and cache not base job

* correction

* updated ruby version at the orb level

* trying to update ruby version

* removed setting ruby version in config.yml

* matching image ruby supported version

* pre-installing simulator on each test job

* update ruby-version to get 3.0.5
  • Loading branch information
msadoon committed May 15, 2023
1 parent d1b0762 commit 6a48e5a
Show file tree
Hide file tree
Showing 464 changed files with 97 additions and 47 deletions.
8 changes: 6 additions & 2 deletions .circleci/config.yml
@@ -1,15 +1,16 @@
version: 2.1

orbs:
macos: circleci/macos@2
aws-cli: circleci/aws-cli@3.1
codecov: codecov/codecov@1.1.3

aws_cli_setup: &aws_cli_setup
role-arn: $AWS_ROLE_ARN

xcode_version: &xcode_version 13.3.1
xcode_version: &xcode_version 14.2
iphone_name: &iphone_name iPhone 8
preload_simulator: &preload_simulator xcrun instruments -w "iPhone 8 (15.4) [" || true
preload_simulator: &preload_simulator xcrun instruments -w "iPhone 8 (15.5) [" || true

# Works around an issue in xcodebuild where it requires GitHub to have been added to the known_hosts in order for it to clone dependencies.
spm_ssh_workaround: &spm_ssh_workaround for ip in $(dig @1.1.1.1 github.com +short); do ssh-keyscan github.com,$ip; ssh-keyscan $ip; done 2>/dev/null >> ~/.ssh/known_hosts
Expand Down Expand Up @@ -53,6 +54,9 @@ test_job: &test_job
- run:
name: Download GraphQL Schema
command: bin/apollo-schema-download.sh
- run:
name: Pre-install simulator
command: xcrun simctl create "iPhone 8 (15.5)" com.apple.CoreSimulator.SimDeviceType.iPhone-8 com.apple.CoreSimulator.SimRuntime.iOS-15-5
- run:
name: Pre-load simulator
command: *preload_simulator
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
@@ -1 +1 @@
ruby-2.6.3
ruby-3.0.5
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 6a48e5a

Please sign in to comment.