final pr fixes

Kickstarter-iOS/Features/Dashboard/Controller/DashboardViewController.swift

@@ -53,6 +53,10 @@ internal final class DashboardViewController: UITableViewController {
     self.viewModel.inputs.viewWillAppear(animated: animated)
 
     self.showDeprecationWarning()
+  }
+
+  override func viewDidAppear(_ animated: Bool) {
+    super.viewDidAppear(animated)
 
     self.updateTableViewBottomContentInset()
   }
@@ -212,11 +216,10 @@ internal final class DashboardViewController: UITableViewController {
   }
 
   private func updateTableViewBottomContentInset() {
-    if let tabController = self.tabBarController as? RootTabBarViewController,
-      let deprecationWarningHostingController = deprecationWarningHostingController {
+    if let deprecationWarningHostingController = deprecationWarningHostingController {
       self.tableView.contentInset
-        .bottom = (tabController.tabBar.bounds.height + deprecationWarningHostingController.view.bounds
-          .height)
+        .bottom = deprecationWarningHostingController.view.bounds
+        .height
     }
   }
 

Kickstarter-iOS/Features/DashboardDeprecationBanner/DashboardDeprecationView.swift

@@ -4,7 +4,9 @@ import SwiftUI
 struct DashboardDeprecationView: View {
   private let contentPadding = 12.0
   private let imageSizeMultiplier = 1.5
-  private let deprecationDateText = formatted(dateString: "2023-08-14")
+  private var deprecationDateText: String {
+    self.formatted(dateString: "2023-08-14")
+  }
 
   var body: some View {
     HStack {
@@ -25,26 +27,26 @@ struct DashboardDeprecationView: View {
     .frame(maxWidth: .infinity, alignment: .center)
     .background(Color(UIColor.ksr_alert))
   }
-}
-
-private func formatted(dateString: String) -> String {
-  let date = toDate(dateString: dateString)
-  return Format.date(
-    secondsInUTC: date.timeIntervalSince1970,
-    template: "MMMM d, yyyy",
-    timeZone: UTCTimeZone
-  )
-}
 
-private func toDate(dateString: String) -> Date {
-  // Always use UTC timezone here this date should be timezone agnostic
-  guard let date = Format.date(
-    from: dateString,
-    dateFormat: "yyyy-MM-dd",
-    timeZone: UTCTimeZone
-  ) else {
-    fatalError("Unable to parse date format")
+  private func formatted(dateString: String) -> String {
+    let date = self.toDate(dateString: dateString)
+    return Format.date(
+      secondsInUTC: date.timeIntervalSince1970,
+      template: "MMMM d, yyyy",
+      timeZone: UTCTimeZone
+    )
   }
 
-  return date
+  private func toDate(dateString: String) -> Date {
+    // Always use UTC timezone here this date should be timezone agnostic
+    guard let date = Format.date(
+      from: dateString,
+      dateFormat: "yyyy-MM-dd",
+      timeZone: UTCTimeZone
+    ) else {
+      fatalError("Unable to parse date format")
+    }
+
+    return date
+  }
 }

Kickstarter-iOS/Features/RootTabBar/RootTabBarViewController.swift

@@ -260,10 +260,11 @@ public final class RootTabBarViewController: UITabBarController, MessageBannerVi
       case let .search(index):
         _ = tabBarItem(atIndex: index) ?|> searchTabBarItemStyle
       case let .dashboard(index):
-        let featureFlaggedTabBarItemStyle = self
-          .isDashboardViewControllerDisplayable() ? dashboardTabBarItemStyle :
-          profileTabBarItemStyle(isLoggedIn: data.isLoggedIn, isMember: data.isMember)
-        _ = tabBarItem(atIndex: index) ?|> featureFlaggedTabBarItemStyle
+        let style = self
+          .isTabBarItemLastItem(for: index) ?
+          profileTabBarItemStyle(isLoggedIn: data.isLoggedIn, isMember: data.isMember) :
+          dashboardTabBarItemStyle
+        _ = tabBarItem(atIndex: index) ?|> style
       case let .profile(avatarUrl, index):
         _ = tabBarItem(atIndex: index)
           ?|> profileTabBarItemStyle(isLoggedIn: data.isLoggedIn, isMember: data.isMember)
@@ -307,21 +308,12 @@ public final class RootTabBarViewController: UITabBarController, MessageBannerVi
     }
   }
 
-  fileprivate func isDashboardViewControllerDisplayable() -> Bool {
-    guard let navigationControllers = self.viewControllers as? [UINavigationController] else {
+  fileprivate func isTabBarItemLastItem(for index: Int) -> Bool {
+    guard let tabBarItemEndIndex = self.tabBar.items?.endIndex else {
       return false
     }
 
-    var foundDashboardViewController = false
-
-    for navController in navigationControllers {
-      if let dashboardVC = navController.viewControllers.first as? DashboardViewController {
-        foundDashboardViewController = true
-        break
-      }
-    }
-
-    return foundDashboardViewController
+    return tabBarItemEndIndex - 1 == index
   }
 
   fileprivate func tabBarItem(atIndex index: Int) -> UITabBarItem? {