MBL-1158: Add feature flag for logging in with OAuth (#1928)

* MBL-1158: Add feature flag for logging in with OAuth * Fix failure in RemoteConfigFeatureFlagToolsViewModelTests
kickstarter · Feb 5, 2024 · c1f77f0 · c1f77f0
1 parent 9a7c871
commit c1f77f0
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 2 deletions.
diff --git a/...agToolsViewControllerTests/testRemoteConfigFeatureFlagToolsViewController.1.png b/...agToolsViewControllerTests/testRemoteConfigFeatureFlagToolsViewController.1.png
diff --git a/Library/RemoteConfig/RemoteConfigFeature+Helpers.swift b/Library/RemoteConfig/RemoteConfigFeature+Helpers.swift
@@ -30,3 +30,7 @@ public func featurePostCampaignPledgeEnabled() -> Bool {
 public func featureReportThisProjectEnabled() -> Bool {
   featureEnabled(feature: .reportThisProjectEnabled)
 }
+
+public func featureLoginWithOAuthEnabled() -> Bool {
+  featureEnabled(feature: .loginWithOAuthEnabled)
+}
diff --git a/Library/RemoteConfig/RemoteConfigFeature+HelpersTests.swift b/Library/RemoteConfig/RemoteConfigFeature+HelpersTests.swift
@@ -118,4 +118,20 @@ final class RemoteConfigFeatureHelpersTests: TestCase {
         whenRemoteConfigFeatureIsFalse: .reportThisProjectEnabled
       )
   }
+
+  func testLoginWithOAuth_RemoteConfig_FeatureFlag_True() {
+    self
+      .assert(
+        featureFlagIsTrue: featureLoginWithOAuthEnabled,
+        whenRemoteConfigFeatureIsTrue: .loginWithOAuthEnabled
+      )
+  }
+
+  func testLoginWithOAuth_RemoteConfig_FeatureFlag_False() {
+    self
+      .assert(
+        featureFlagIsFalse: featureLoginWithOAuthEnabled,
+        whenRemoteConfigFeatureIsFalse: .loginWithOAuthEnabled
+      )
+  }
 }
diff --git a/Library/RemoteConfig/RemoteConfigFeature.swift b/Library/RemoteConfig/RemoteConfigFeature.swift
@@ -7,6 +7,7 @@ public enum RemoteConfigFeature: String, CaseIterable {
   case facebookLoginInterstitialEnabled = "facebook_interstitial"
   case postCampaignPledgeEnabled = "post_campaign_pledge"
   case reportThisProjectEnabled = "report_this_project"
+  case loginWithOAuthEnabled = "ios_oauth"
 }
 
 extension RemoteConfigFeature: CustomStringConvertible {
@@ -18,6 +19,7 @@ extension RemoteConfigFeature: CustomStringConvertible {
     case .facebookLoginInterstitialEnabled: return "Facebook Login Interstitial"
     case .postCampaignPledgeEnabled: return "Post Campaign Pledging"
     case .reportThisProjectEnabled: return "Report This Project"
+    case .loginWithOAuthEnabled: return "Login with OAuth"
     }
   }
 }
diff --git a/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModel.swift b/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModel.swift
@@ -97,6 +97,8 @@ private func isFeatureEnabled(_ feature: RemoteConfigFeature) -> Bool {
     return featurePostCampaignPledgeEnabled()
   case .reportThisProjectEnabled:
     return featureReportThisProjectEnabled()
+  case .loginWithOAuthEnabled:
+    return featureLoginWithOAuthEnabled()
   }
 }
 

diff --git a/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModelTests.swift b/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModelTests.swift
@@ -27,7 +27,8 @@ final class RemoteConfigFlagToolsViewModelTests: TestCase {
         RemoteConfigFeature.darkModeEnabled.rawValue: true,
         RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue: true,
         RemoteConfigFeature.postCampaignPledgeEnabled.rawValue: true,
-        RemoteConfigFeature.reportThisProjectEnabled.rawValue: true
+        RemoteConfigFeature.reportThisProjectEnabled.rawValue: true,
+        RemoteConfigFeature.loginWithOAuthEnabled.rawValue: true
       ]
 
     withEnvironment(remoteConfigClient: mockRemoteConfigClient) {
@@ -51,7 +52,8 @@ final class RemoteConfigFlagToolsViewModelTests: TestCase {
         RemoteConfigFeature.darkModeEnabled.rawValue: false,
         RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue: true,
         RemoteConfigFeature.postCampaignPledgeEnabled.rawValue: false,
-        RemoteConfigFeature.reportThisProjectEnabled.rawValue: false
+        RemoteConfigFeature.reportThisProjectEnabled.rawValue: false,
+        RemoteConfigFeature.loginWithOAuthEnabled.rawValue: true
       ]
 
     withEnvironment(remoteConfigClient: mockRemoteConfigClient) {