[PAY-1980] Update Backing Errored Pledge Flow (#1747)

* removed logic for gating errored pledge flow. * corrected a syntax issue with signals being incorrectly parsed.
kickstarter · Oct 13, 2022 · d382b78 · d382b78
1 parent 3dfa5c7
commit d382b78
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/Library/ViewModels/PledgePaymentMethodsViewModel.swift b/Library/ViewModels/PledgePaymentMethodsViewModel.swift
@@ -291,15 +291,7 @@ public final class PledgePaymentMethodsViewModel: PledgePaymentMethodsViewModelT
     let didTapToAddNewCard = self.didSelectRowAtIndexPathProperty.signal.skipNil()
       .filter { $0.section == PaymentMethodsTableViewSection.addNewCard.rawValue }
 
-    let paymentSheetOnPledgeContext = context
-      .map { context -> Bool in
-        guard context.isCreating || context.isUpdating,
-          context != .fixPaymentMethod else {
-          return false
-        }
-
-        return paymentSheetEnabled
-      }
+    let paymentSheetOnPledgeContext = context.map { _ in paymentSheetEnabled }
 
     self.goToAddCardScreen = Signal.combineLatest(
       project,

diff --git a/Library/ViewModels/PledgePaymentMethodsViewModelTests.swift b/Library/ViewModels/PledgePaymentMethodsViewModelTests.swift
@@ -923,7 +923,7 @@ final class PledgePaymentMethodsViewModelTests: TestCase {
     }
   }
 
-  func testGoToAddNewCard_PledgeContext_PaymentSheetEnabled_Success() {
+  func testGoToAddNewCard_PledgeContext_PaymentSheetEnabled_Failure() {
     let project = Project.template
 
     let mockOptimizelyClient = MockOptimizelyClient()
@@ -957,7 +957,7 @@ final class PledgePaymentMethodsViewModelTests: TestCase {
     }
   }
 
-  func testGoToAddNewCard_UpdatePledgeContext_PaymentSheetEnabled_Success() {
+  func testGoToAddNewCard_UpdatePledgeContext_PaymentSheetEnabled_Failure() {
     let project = Project.template
 
     let mockOptimizelyClient = MockOptimizelyClient()
@@ -991,7 +991,7 @@ final class PledgePaymentMethodsViewModelTests: TestCase {
     }
   }
 
-  func testGoToAddNewCard_UpdateRewardContexts_PaymentSheetEnabled_Success() {
+  func testGoToAddNewCard_UpdateRewardContexts_PaymentSheetEnabled_Failure() {
     let project = Project.template
 
     let mockOptimizelyClient = MockOptimizelyClient()
@@ -1025,7 +1025,7 @@ final class PledgePaymentMethodsViewModelTests: TestCase {
     }
   }
 
-  func testGoToAddNewCard_ChangePaymentMethodContext_PaymentSheetEnabled_Success() {
+  func testGoToAddNewCard_ChangePaymentMethodContext_PaymentSheetEnabled_Failure() {
     let project = Project.template
 
     let mockOptimizelyClient = MockOptimizelyClient()
@@ -1060,7 +1060,7 @@ final class PledgePaymentMethodsViewModelTests: TestCase {
     }
   }
 
-  func testGoToAddNewCard_FixPaymentMethodContext_PaymentSheetEnabled_Success() {
+  func testGoToAddNewCard_FixPaymentMethodContext_PaymentSheetEnabled_Failure() {
     let project = Project.template
 
     let mockOptimizelyClient = MockOptimizelyClient()
@@ -1088,8 +1088,8 @@ final class PledgePaymentMethodsViewModelTests: TestCase {
 
       self.scheduler.run()
 
-      XCTAssertEqual(self.goToAddCardIntent.values.count, 1)
-      XCTAssertEqual(self.goToAddStripeCardIntent.values.count, 0)
+      XCTAssertEqual(self.goToAddCardIntent.values.count, 0)
+      XCTAssertEqual(self.goToAddStripeCardIntent.values.count, 1)
     }
   }