MBL-904: Remove feature flag for tab "Use of AI"

kickstarter · Jan 17, 2024 · ebb41ad · ebb41ad
1 parent e64ceaa
commit ebb41ad
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 41 deletions.
diff --git a/...agToolsViewControllerTests/testRemoteConfigFeatureFlagToolsViewController.1.png b/...agToolsViewControllerTests/testRemoteConfigFeatureFlagToolsViewController.1.png
diff --git a/Library/RemoteConfig/RemoteConfigFeature+Helpers.swift b/Library/RemoteConfig/RemoteConfigFeature+Helpers.swift
@@ -34,10 +34,3 @@ public func featureReportThisProjectEnabled() -> Bool {
     (AppEnvironment.current.remoteConfigClient?
       .isFeatureEnabled(featureKey: RemoteConfigFeature.reportThisProjectEnabled) ?? false)
 }
-
-public func featureUseOfAIProjectTabEnabled() -> Bool {
-  return AppEnvironment.current.userDefaults
-    .remoteConfigFeatureFlags[RemoteConfigFeature.useOfAIProjectTab.rawValue] ??
-    (AppEnvironment.current.remoteConfigClient?
-      .isFeatureEnabled(featureKey: RemoteConfigFeature.useOfAIProjectTab) ?? false)
-}
diff --git a/Library/RemoteConfig/RemoteConfigFeature+HelpersTests.swift b/Library/RemoteConfig/RemoteConfigFeature+HelpersTests.swift
@@ -92,22 +92,4 @@ final class RemoteConfigFeatureHelpersTests: TestCase {
       XCTAssertFalse(featureReportThisProjectEnabled())
     }
   }
-
-  func testUseOfAIProjectTab_RemoteConfig_FeatureFlag_False() {
-    let mockRemoteConfigClient = MockRemoteConfigClient()
-      |> \.features .~ [RemoteConfigFeature.useOfAIProjectTab.rawValue: false]
-
-    withEnvironment(remoteConfigClient: mockRemoteConfigClient) {
-      XCTAssertFalse(featureUseOfAIProjectTabEnabled())
-    }
-  }
-
-  func testUseOfAIProjectTab_RemoteConfig_FeatureFlag_True() {
-    let mockRemoteConfigClient = MockRemoteConfigClient()
-      |> \.features .~ [RemoteConfigFeature.useOfAIProjectTab.rawValue: true]
-
-    withEnvironment(remoteConfigClient: mockRemoteConfigClient) {
-      XCTAssertTrue(featureUseOfAIProjectTabEnabled())
-    }
-  }
 }
diff --git a/Library/RemoteConfig/RemoteConfigFeature.swift b/Library/RemoteConfig/RemoteConfigFeature.swift
@@ -6,7 +6,6 @@ public enum RemoteConfigFeature: String, CaseIterable {
   case darkModeEnabled = "dark_mode"
   case facebookLoginInterstitialEnabled = "facebook_interstitial"
   case reportThisProjectEnabled = "report_this_project"
-  case useOfAIProjectTab = "use_of_ai_project_tab"
 }
 
 extension RemoteConfigFeature: CustomStringConvertible {
@@ -17,7 +16,6 @@ extension RemoteConfigFeature: CustomStringConvertible {
     case .darkModeEnabled: return "Dark Mode"
     case .facebookLoginInterstitialEnabled: return "Facebook Login Interstitial"
     case .reportThisProjectEnabled: return "Report This Project"
-    case .useOfAIProjectTab: return "Use of AI Project Tab"
     }
   }
 }
diff --git a/Library/ViewModels/ProjectNavigationSelectorViewModel.swift b/Library/ViewModels/ProjectNavigationSelectorViewModel.swift
@@ -67,8 +67,7 @@ public final class ProjectNavigationSelectorViewModel: ProjectNavigationSelector
 
       var includeAIDisclosure = false
 
-      if let aiDisclosure = extendedProjectProperties
-        .aiDisclosure, aiDisclosure.involvesAi, featureUseOfAIProjectTabEnabled() {
+      if let aiDisclosure = extendedProjectProperties.aiDisclosure, aiDisclosure.involvesAi {
         includeAIDisclosure = true
       }
 

diff --git a/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModel.swift b/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModel.swift
@@ -95,8 +95,6 @@ private func isFeatureEnabled(_ feature: RemoteConfigFeature) -> Bool {
     return featureFacebookLoginInterstitialEnabled()
   case .reportThisProjectEnabled:
     return featureReportThisProjectEnabled()
-  case .useOfAIProjectTab:
-    return featureUseOfAIProjectTabEnabled()
   }
 }
 
@@ -119,9 +117,6 @@ private func getValueFromUserDefaults(for feature: RemoteConfigFeature) -> Bool?
   case .reportThisProjectEnabled:
     return AppEnvironment.current.userDefaults
       .remoteConfigFeatureFlags[RemoteConfigFeature.reportThisProjectEnabled.rawValue]
-  case .useOfAIProjectTab:
-    return AppEnvironment.current.userDefaults
-      .remoteConfigFeatureFlags[RemoteConfigFeature.useOfAIProjectTab.rawValue]
   }
 }
 
@@ -144,8 +139,5 @@ private func setValueInUserDefaults(for feature: RemoteConfigFeature, and value:
   case .reportThisProjectEnabled:
     return AppEnvironment.current.userDefaults
       .remoteConfigFeatureFlags[RemoteConfigFeature.reportThisProjectEnabled.rawValue] = value
-  case .useOfAIProjectTab:
-    return AppEnvironment.current.userDefaults
-      .remoteConfigFeatureFlags[RemoteConfigFeature.useOfAIProjectTab.rawValue] = value
   }
 }
diff --git a/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModelTests.swift b/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModelTests.swift
@@ -26,8 +26,7 @@ final class RemoteConfigFlagToolsViewModelTests: TestCase {
         RemoteConfigFeature.consentManagementDialogEnabled.rawValue: true,
         RemoteConfigFeature.darkModeEnabled.rawValue: true,
         RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue: true,
-        RemoteConfigFeature.reportThisProjectEnabled.rawValue: true,
-        RemoteConfigFeature.useOfAIProjectTab.rawValue: true
+        RemoteConfigFeature.reportThisProjectEnabled.rawValue: true
       ]
 
     withEnvironment(remoteConfigClient: mockRemoteConfigClient) {
@@ -50,8 +49,7 @@ final class RemoteConfigFlagToolsViewModelTests: TestCase {
         RemoteConfigFeature.consentManagementDialogEnabled.rawValue: true,
         RemoteConfigFeature.darkModeEnabled.rawValue: false,
         RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue: true,
-        RemoteConfigFeature.reportThisProjectEnabled.rawValue: false,
-        RemoteConfigFeature.useOfAIProjectTab.rawValue: false
+        RemoteConfigFeature.reportThisProjectEnabled.rawValue: false
       ]
 
     withEnvironment(remoteConfigClient: mockRemoteConfigClient) {