Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-699] Align Reward Close Button w/ Project Close Button #1025

Merged
merged 5 commits into from
Jan 21, 2020

Conversation

cdolm92
Copy link
Contributor

@cdolm92 cdolm92 commented Jan 9, 2020

📲 What

In rewards carousel, X in the top bar is in a different location than the project page so we're moving it to the same location as rewards carousel page.

🤔 Why

So that transitioning between these screens is smoother.

👀 See

Before 🐛 After 🦋
Simulator Screen Shot - iPhone X - 2020-01-09 at 17 28 39 Simulator Screen Shot - iPhone X - 2020-01-09 at 17 04 23

✅ Acceptance criteria

  • X buttons in Project Page and Rewards Carousel appears in the same position

@Scollaco
Copy link
Contributor

I noticed that the X on the Project Page is still a little misaligned. This should be just a matter of moving it a bit more:

x_buttons_alignment

Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Very nice, @cdolm92 ⭐️

@cdolm92 cdolm92 merged commit 3fa9c56 into master Jan 21, 2020
@cdolm92 cdolm92 deleted the align-project-page-close-button branch January 21, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants