Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-773] Additional Login Flow Events #1031

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Jan 13, 2020

📲 What

Adds two additional tracking events for the login flow:

  • Two-Factor Confirmation Viewed
  • Forgot Password Viewed

🤔 Why

To track when the user views the 2FA screen and also when they view the "Reset Password" screen

🛠 How

Also added missed properties and tests to the Signup Button Clicked event.

✅ Acceptance criteria

With the KOALA_TRACKING environment variable set to true, test the following events:

  • Navigate to the Forgot Password screen. You should see the event Forgot Password Viewed tracked on the data lake
  • Log in with a 2FA-enabled account. When you're taken to the 2FA screen, you should see the event Two-Factor Confirmation Viewed fire on the data lake.

@ifbarrera ifbarrera merged commit 276918a into master Jan 15, 2020
@ifbarrera ifbarrera deleted the NT-773-additional-login-events branch January 15, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants