-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-708] A11y statement #1040
[NT-708] A11y statement #1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, @cdolm92 . I only left a small comment regarding the test on HelpTypeTests.swift
, but everything else looks good.
@@ -66,6 +69,8 @@ public enum HelpType: SettingsCellTypeProtocol, CaseIterable { | |||
return "Terms" | |||
case .trust: | |||
return "Trust & Safety" | |||
case .accessibility: | |||
return "Accessibility Statement" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the .accessibility
case on the testAccessibilityTraits
test?
📲 What
Accessibility link added to settings
🤔 Why
Users understand Kickstarter’s accessibility standards.
👀 See
Trello, screenshots, external resources?
♿️ Accessibility
✅ Acceptance criteria
⏰ TODO