Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-730] Pledge screen header label fix #1047

Merged
merged 6 commits into from
Jan 23, 2020

Conversation

Scollaco
Copy link
Contributor

@Scollaco Scollaco commented Jan 23, 2020

πŸ“² What

  • Fixed a visual bug where the date label, when the text is too long, adds a new line.

πŸ€” Why

  • To match the design.

πŸ›  How

  • Instead of setting the numberOfLines to 0, I set the minimumScaleFactor to 0.5. This way, the text will scale down up to half of its original size before it truncates.

πŸ‘€ See

Before πŸ› After πŸ¦‹
Screenshot 2020-01-23 at 11 06 31 Screenshot 2020-01-23 at 11 04 58

♿️ Accessibility

  • Works with VoiceOver
  • Supports Dynamic Type

βœ… Acceptance criteria

  • Search for the project Mawu and select the Get the original SOUNDTRACK of MAWU reward. The header on the Pledge screen should show Estimated delivery September 2020 in one line. (You can select any project, but the estimated delivery text should be long enough to prove that the label is not breaking line).

Copy link
Contributor

@cdolm92 cdolm92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!! πŸ›³πŸ›³πŸ‘©πŸΎβ€βœˆοΈ

@Scollaco Scollaco merged commit 018cd4c into master Jan 23, 2020
@Scollaco Scollaco deleted the NT-730_pledge-header-label-fix branch January 23, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants