Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NT-728] Adds staging and native.dev as Associated domains #1048

Merged
merged 4 commits into from
Jan 23, 2020
Merged

[NT-728] Adds staging and native.dev as Associated domains #1048

merged 4 commits into from
Jan 23, 2020

Conversation

Scollaco
Copy link
Contributor

📲 What

  • Adds staging and native.dev to our list of Associated domains.

🤔 Why

  • This is part of the work to set up deep/universal links on test environments.
  • Related PR
  • JIRA ticket

🛠 How

  • Adding staging.kickstarter.com and native.dev.kickstarter.com to Alpha.entitlements and Debug.entitlements plists.

✅ Acceptance criteria

  • This will be tested once we are ready for emails coming from staging/test environments.

justinswart
justinswart approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Scollaco Scollaco merged commit ac8c660 into master Jan 23, 2020
@Scollaco Scollaco deleted the NT-728_staging-native-dev-associated-domains branch January 23, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinswart justinswart justinswart approved these changes

Assignees

@justinswart justinswart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Scollaco @justinswart