Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-549] Keyboard dismissal when user taps save #1058

Merged

Conversation

cdolm92
Copy link
Contributor

@cdolm92 cdolm92 commented Feb 4, 2020

πŸ“² What

Fixed bug where tapping Save from the creditCardTextField dismisses the keyboard.

πŸ€” Why

Keyboard was blocking the user from seeing error messages, which show up below the screen.

πŸ›  How

Setting the zipcodeTextField as the first responder after the user finished editing the creditCardTextField prevented the keyboard from being dismissed.

πŸ‘€ See

Before πŸ› After πŸ¦‹
add-credit-card-before add-new-card-keyboard-fix

βœ… Acceptance criteria

  • Go to a project page, follow steps to pledge on credit card page, select option to add a new card, fill out form with this card number: 4000000000000119 (enter any cardholder name, expiry, cvc, zip), tap Save. Keyboard dismisses and processing_error message is shown.
  • Keeping the new card form open, edit the card number to 4000000000000101, tap Save. Keyboard should dismiss and cvc error is shown

…NT-549-keyboard-dismisses-when-save-tapped-in-add-new-card
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this seems to fix the issue with the keyboard covering the error. I think you can also remove the paymentCardTextFieldDidEndEditing now? Didn't see any other outputs depending on it.

I think we should create a ticket to improve this screen by adding an accessory view to the numeric keyboard so that it has like a next button to allow the user to easily move from the CVC field to the zip code field. This would be easier if the numeric keyboard could have a return key but iOS doesn't support that.

@cdolm92 cdolm92 merged commit 84a3ca9 into master Feb 5, 2020
@cdolm92 cdolm92 deleted the NT-549-keyboard-dismisses-when-save-tapped-in-add-new-card branch February 5, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants