[NT-892, NT-893] (2/3) Landing page carousel #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
reviewed
Feb 26, 2020
| @@ -61,6 +62,7 @@ public final class LandingPageViewController: UIViewController { | |||
| .observeForUI() | |||
| .observeValues { [weak self] cards in | |||
| self?.configureCards(with: cards) | |||
| self?.updatePageControl(with: cards) | |||
There was a problem hiding this comment.
I wonder if this should be a separate output pageControlCount so it can be tested independently 🤔
| public var quantity: String? { | ||
| switch self { | ||
| case .successfulProjects: | ||
| return Strings.Total_plus(total: "177,000") |
There was a problem hiding this comment.
Should we use Format.wholeNumber here so the number is localized?
| case .successfulProjects: | ||
| return Strings.Total_plus(total: "177,000") | ||
| case .totalBackers: | ||
| return Strings.Million_plus(total_amount: "17") |
There was a problem hiding this comment.
Same here though this one is probably fine.
Generated by 🚫 Danger |
ifbarrera
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
. This is the second part of a 3 parts work to create our new LandingPage.
. It adds the
statsandhow tocards to the Landing Page screen.🤔 Why
We want to tell new users a little more about Kickstarter during their first session.
JIRA tickets:
Ticket 1
Ticket 2
🛠 How
👀 See
Trello, screenshots, external resources?
♿️ Accessibility
✅ Acceptance criteria