Remove unneeded update tracking. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoser
reviewed
Mar 17, 2017
| @@ -5,10 +5,10 @@ import Prelude | |||
| import ReactiveSwift | |||
| import Result | |||
|
|
|||
| public struct UpdateData { | |||
| private struct UpdateData { | |||
There was a problem hiding this comment.
oh dang actually you don't even need to use this struct anymore since this context was for the unneeded events sry
luoser
approved these changes
Mar 17, 2017
| public let project: Project | ||
| public let update: Update | ||
| public let context: Koala.UpdateContext | ||
| fileprivate struct UpdateData { |
There was a problem hiding this comment.
you could also kill this UpdateData struct entirely and just use a pair for project and update if your heart desires :)
There was a problem hiding this comment.
yah for sure but just wanna do the minimal work right now. or you can clean up your own mess ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pr #103 added some tracking to updates that isn't needed since it's done on the server side. So just removing that and correcting a few small things.