Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-983] Removing unused errored backings code #1130

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

ifbarrera
Copy link
Contributor

#📲 What

Removes some code that was making a network request for an incomplete feature. This feature is currently being developed on a feature branch., and should never have been merged into master.

🤔 Why

Because we shouldn't be making network requests for data that is not being used.

🛠 How

Deleted the unused code. This code will be re-added as part of the complete feature when the feature-errored-pledges branch merges.

✅ Acceptance criteria

  • Run the app and sign in. Navigate to the Activity tab. Observe in the logs that the errored backings query is not dispatched.

@ifbarrera ifbarrera merged commit d80b606 into master Mar 30, 2020
@ifbarrera ifbarrera deleted the NT-983-remove-unused-code branch March 30, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants