Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1032] Watch Project Button Clicked Event #1136

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

ifbarrera
Copy link
Contributor

πŸ“² What

Adds the whitelisted Watch Project Button Clicked event that fires when the "Watch" button is tapped either on the discover cards or in the project page.

πŸ€” Why

So we can track when users tap the "Watch" button in Amplitude.

πŸ›  How

  • adds Watch Project Button Clicked event to the datalake whitelisted events enum
  • updates the naming of the tracking function, adds project properties, optionally discovery properties, and context location
  • in WatchProjectViewModel, the event will be queued immediately when the user taps the button (previously we would wait for the request to succeed before tracking)

πŸ‘€ See

image

βœ… Acceptance criteria

Make sure you have the KOALA_TRACKING_ENABLED environment variable enabled while testing.

  • Launch the app. Tap the "Save" icon on any discovery postcard cell. You should see in the logs a tracking event for the data lake: Watch Project Button Clicked with the context_location property set to explore_screen, and the event should contain project properties and discovery properties.
  • Launch the app. Navigate to any project. Tap the "Save" icon on the navigation bar in the project page. You should see in the logs a tracking event for the data lake: Watch Project Button Clicked with the context_location property set to project_screen, and the event properties should include project properties.

@ifbarrera ifbarrera merged commit 70cfc0b into master Apr 2, 2020
@ifbarrera ifbarrera deleted the NT-1032-watch-project-events branch April 7, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants