Fixed live styles #114
Merged
Fixed live styles #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theginbin
reviewed
Mar 17, 2017
Library/Styles/BaseStyles.swift
Outdated
| @@ -119,5 +125,12 @@ private let baseNavigationBarStyle = | |||
| NSForegroundColorAttributeName: UIColor.black, | |||
| NSFontAttributeName: UIFont.ksr_callout() | |||
| ] | |||
| <> UINavigationBar.lens.translucent .~ false | |||
There was a problem hiding this comment.
quick q, the default translucent value is true. how come this was removed?
There was a problem hiding this comment.
ah sorry, i thought the default was false and it seemed to work, but now i see it's wrong. fixing...
There was a problem hiding this comment.
yeah apple loves that translucent look
mbrandonw
commented
Mar 17, 2017
| @@ -385,7 +385,7 @@ | |||
| <constraint firstAttribute="width" constant="80" id="vCB-Xb-z6f"/> | |||
| </constraints> | |||
| </imageView> | |||
| <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="HERTZFELDT ON BLU-RAY" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="2" baselineAdjustment="alignBaselines" minimumScaleFactor="0.69999999999999996" translatesAutoresizingMaskIntoConstraints="NO" id="peK-ts-qtm" customClass="StyledLabel" customModule="Library"> | |||
There was a problem hiding this comment.
sorry saw this StyledLabel getting logged to the console so wanted to remove. unrelated to this pr but still nice to get rid of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for posterity, but #104 messed with some nav bar styles on our live streaming controllers and this fixes that. Will merge when tests pass.