[NT-969] Show full-screen "processing" state during create/update backing requests #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scollaco
reviewed
Apr 9, 2020
There was a problem hiding this comment.
Very nice, @ifbarrera . I just left a minor comment and a suggestion.
| @@ -744,6 +764,7 @@ public class PledgeViewModel: PledgeViewModelType, PledgeViewModelInputs, Pledge | |||
| public let paymentMethodsViewHidden: Signal<Bool, Never> | |||
| public let pledgeAmountViewHidden: Signal<Bool, Never> | |||
| public let pledgeAmountSummaryViewHidden: Signal<Bool, Never> | |||
| public let processingViewIsHidden: Signal<Bool, Never> | |||
| |> ksr_addSubviewToParent() | ||
| |> ksr_constrainViewToEdgesInParent() | ||
|
|
||
| self.processingView.activityIndicator.startAnimating() |
There was a problem hiding this comment.
I think we could start animating the indicator in the ProcessingView's init method. This way we don't need to expose its UIActivityIndicatorView property and it's one less thing to worry about, since we don't need to start/stop the animation.
Scollaco
reviewed
Apr 10, 2020
| |> \.numberOfLines .~ 0 | ||
| |> \.text %~ { _ -> String in | ||
| var processingString = Strings.project_checkout_finalizing_title() | ||
| processingString.append("...") |
There was a problem hiding this comment.
Considering the localizations, I wonder if it's ok to append the ... to the string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adds a full-screen "processing" view that displays when a create or update backing request is in flight, to prevent users from interacting with the app during critical requests.
🤔 Why
We want to guarantee that the user can't submit another backing request while one is in flight.
🛠 How
ProcessingViewwhich is added to the app'smainWindowwhen either thecreateBackingorupdateBackingrequests are in flightProcessingViewis removed from the hierarchy when the request terminates👀 See
Trello, screenshots, external resources?
✅ Acceptance criteria
⏰ TODO