Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NT-1181] Add "Editorial Card Clicked" event when the personalization cell is tapped #1170

Merged
merged 2 commits into from
Apr 22, 2020
Merged

[NT-1181] Add "Editorial Card Clicked" event when the personalization cell is tapped #1170

merged 2 commits into from
Apr 22, 2020

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Apr 22, 2020 •
edited by justinswart
Loading

📲 What

Add tracking for when the category personalization cell in discover is tapped.

🤔 Why

Missed adding this tracking event during the first round of events for the category personalization experiment.

🛠 How

  • added tracking event to the data lake
  • added tracking event to Optimizely
  • updated the tests

✅ Acceptance criteria

  • after completing the category personalization flow, when tapping the personalization cell at the top of discovery, verify that the "Editorial Card Clicked" event is sent to Optimizely, and also to the data lake

justinswart
justinswart approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ifbarrera ifbarrera merged commit 5756fa8 into master Apr 22, 2020
@ifbarrera ifbarrera deleted the NT-1181-editorial-tracking branch April 22, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinswart justinswart justinswart approved these changes

Assignees

@justinswart justinswart

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ifbarrera @justinswart