[NT-1175] Coalesce experimental variants to control #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
reviewed
Apr 23, 2020
| @@ -27,6 +27,6 @@ extension OptimizelyExperiment { | |||
| .variant( | |||
| for: OptimizelyExperiment.Key.nativeProjectPageCampaignDetails, | |||
| userAttributes: optimizelyUserAttributes(with: project, refTag: refTag) | |||
| ) | |||
There was a problem hiding this comment.
I think the function return value can also be changed to OptimizelyExperiment.Variant if we're coalescing?
There was a problem hiding this comment.
Ah thanks - I had it like that but then reverted to right a failing test and forgot to switch back 😅
ifbarrera
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Coalesces optional
OptimizelyExperiment.Variant?values to.control.🤔 Why
We've received a handful of bug reports in which the read more about the campaign button is missing on the project page. We suspect this might occur if the Optimizely client fails to initialize and the
skipNil()on the signal that configures the button causes it to never emit.🛠 How
Coalesced
nilvalues to.controlin functions where we return an optional value for the variant.✅ Acceptance criteria