Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1529] Add PLN Currency Selection #1298

Merged
merged 7 commits into from Sep 22, 2020

Conversation

justinswart
Copy link
Contributor

📲 What

Adds the Polish Złoty (PLN) to our currency selection.

🤔 Why

Poland is a country that we will soon be rolling out currency support to.

🛠 How

  • Added translations for the currency string.
  • Updated our Currency type which makes the currency available for selection by way of its CaseIterable conformance.

👀 See

Before 🐛 After 🦋
image image

✅ Acceptance criteria

  • Navigate to your user settings, update your currency to PLN, this change should be persisted. Note: This work is still pending on the back-end and this PR is blocked for now.

@justinswart justinswart added needs review blocked a PR that is blocked for external reasons labels Sep 21, 2020
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1298 into master will decrease coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1298      +/-   ##
==========================================
- Coverage   79.35%   79.35%   -0.01%     
==========================================
  Files        1109     1109              
  Lines      107066   107077      +11     
==========================================
+ Hits        84963    84966       +3     
- Misses      22103    22111       +8     
Impacted Files Coverage Δ
Library/Strings.swift 20.69% <0.00%> (-0.02%) ⬇️
Library/Currency.swift 62.50% <50.00%> (-0.84%) ⬇️
...rary/ViewModels/SelectCurrencyViewModelTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1167d19...3e50bed. Read the comment docs.

Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justinswart justinswart merged commit 46a291f into master Sep 22, 2020
@justinswart justinswart deleted the NT-1529-add-pln-currency-selection branch September 22, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked a PR that is blocked for external reasons needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants