Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-55] Remove MultiLineButton from the codebase #1358

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

singhhari
Copy link
Contributor

馃摬 What

We're addressing some technical debt here and removing some unused code. MultiLineButton was originally created to support dynamic type but that did not work out as planned and can now be removed.

馃 Why

The code is currently unused and will not be used in the future.

馃洜 How

Deleted the file and the style snippet.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #1358 (41c1a79) into master (ae3025e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
+ Coverage   86.04%   86.05%   +0.01%     
==========================================
  Files        1100     1099       -1     
  Lines       97640    97628      -12     
==========================================
+ Hits        84011    84012       +1     
+ Misses      13629    13616      -13     
Impacted Files Coverage 螖
Library/Styles/ButtonStyles.swift 0.00% <酶> (酶)
Library/Navigation.swift 77.25% <0.00%> (+0.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ae3025e...41c1a79. Read the comment docs.

@singhhari singhhari merged commit 77cca6c into master Jan 4, 2021
@singhhari singhhari deleted the NT-55-remove-multilinebutton branch January 4, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants