[EP-149] Rename Properties (Phase One) #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
==========================================
+ Coverage 85.83% 85.85% +0.01%
==========================================
Files 1100 1100
Lines 95932 95971 +39
==========================================
+ Hits 82347 82394 +47
+ Misses 13585 13577 -8
Continue to review full report at Codecov.
|
jgsamudio
reviewed
Feb 9, 2021
Library/Tracking/KSRAnalytics.swift
Outdated
| result["reward_id"] = data.rewardId | ||
| result["reward_title"] = data.rewardTitle | ||
| result["reward_is_limited_quantity"] = reward.limit != nil |
There was a problem hiding this comment.
Are we using this logic anywhere else in the app? What do you think about making a computed property on the Reward model?
There was a problem hiding this comment.
Ah good catch. It looks like we are using this same logic for this property and the one below it in another file as well. Changed to a computed property and replaced in a few places.
jgsamudio
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
As part of our ongoing initiative to implement
Segmentand replace our legacy tracking clients, we begin here with some renaming of old events. The Insights team has provided us with a set of properties and the contexts they belong to; this PR is one of many upcoming extensions to the addition of Segment.馃 Why
Our events and their respective tracking clients are present everywhere in this project. It's important that we break down all these tasks into manageable bits. Each phase of work will be represented by anywhere from one to three tickets.
馃洜 How
A lot of the work is in our
KSRAnalyticsfile and the tests that make use of it.