Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused feature flags on ios #1375

Merged
merged 9 commits into from
Feb 22, 2021

Conversation

moderateepheezy
Copy link
Contributor

📲 What

Removed every instance and implementation for Qualtrics flag in the codebase.

🤔 Why

Qualtrics implementation is currently redundant and currently has no use the app.

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #1375 (3aa928e) into master (a7b8d48) will increase coverage by 3.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
+ Coverage   85.85%   89.27%   +3.42%     
==========================================
  Files        1103      883     -220     
  Lines       96059    85787   -10272     
==========================================
- Hits        82471    76588    -5883     
+ Misses      13588     9199    -4389     
Impacted Files Coverage Δ
Library/Extensions/Feature+Helpers.swift 100.00% <ø> (ø)
Library/Extensions/Feature+HelpersTests.swift 100.00% <ø> (ø)
Library/Feature.swift 0.00% <ø> (ø)
...ry/ViewModels/FeatureFlagToolsViewModelTests.swift 100.00% <ø> (ø)
KsApi/models/Activity.swift
KsApi/models/MessageThread.swift
KsApi/mutations/UpdateUserAccountMutation.swift
...s/ProjectStatsEnvelope.CumulativeStatsLenses.swift
KsApi/models/CategoryTests.swift
KsApi/models/ErrorEnvelopeTests.swift
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7b8d48...3aa928e. Read the comment docs.

@singhhari singhhari self-requested a review February 22, 2021 22:20
Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@moderateepheezy moderateepheezy merged commit 056e871 into master Feb 22, 2021
@moderateepheezy moderateepheezy deleted the NT-1664-remove-unused-feature-flags-on-ios branch February 22, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants