[NT-1779] Fix for physical/digital add-ons #1377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
In our
RewardAddOnSelectionViewModel
we are currently getting the value of a reference toshippingRuleExpanded
from the first add on returned from the rewards data. This resulted in physical add ons not being shown forReward
s with a digital add on as the first node returned in the response. This PR updates the logic for determining the correct shipping rule to use.馃 Why
A creator flagged this a couple of weeks ago and, after identifying the issue, only required a fairly minor tweak.