Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1779] Fix for physical/digital add-ons #1377

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Conversation

singhhari
Copy link
Contributor

馃摬 What

In our RewardAddOnSelectionViewModel we are currently getting the value of a reference to shippingRuleExpanded from the first add on returned from the rewards data. This resulted in physical add ons not being shown for Rewards with a digital add on as the first node returned in the response. This PR updates the logic for determining the correct shipping rule to use.

馃 Why

A creator flagged this a couple of weeks ago and, after identifying the issue, only required a fairly minor tweak.

Copy link
Contributor

@jgsamudio jgsamudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Waiting on the snapshots to match the original

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1377 (54370b3) into master (5fdbf1c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1377   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files        1103     1103           
  Lines       96062    96066    +4     
=======================================
+ Hits        82473    82477    +4     
  Misses      13589    13589           
Impacted Files Coverage 螖
...lers/RewardAddOnSelectionViewControllerTests.swift 100.00% <100.00%> (酶)
...ary/ViewModels/RewardAddOnSelectionViewModel.swift 98.14% <100.00%> (+0.02%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5fdbf1c...54370b3. Read the comment docs.

@singhhari singhhari merged commit 3990b8a into master Feb 23, 2021
@singhhari singhhari deleted the NT-1779-add-ons-fix branch February 23, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants