Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-162] Create Properties (phase one) #1379

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Conversation

singhhari
Copy link
Contributor

📲 What

Adding some new and updating some older properties we're using for analytics. This PR concludes the property work for phase one of our Segment implementation.

🤔 Why

Some of our properties were quite old and required some refinement in order to provide value to the folks on our Insights team.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1379 (cb269cc) into master (05a191c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1379   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files        1103     1102    -1     
  Lines       96066    96105   +39     
=======================================
+ Hits        82477    82515   +38     
- Misses      13589    13590    +1     
Impacted Files Coverage Δ
...iewModels/PledgePaymentMethodsViewModelTests.swift 100.00% <ø> (ø)
Library/ViewModels/PledgeViewModelTests.swift 100.00% <ø> (ø)
...y/ViewModels/RewardsCollectionViewModelTests.swift 100.00% <ø> (ø)
Library/Tracking/KSRAnalytics.swift 83.04% <100.00%> (+1.39%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ø)
...ary/ViewModels/PledgePaymentMethodsViewModel.swift 97.80% <100.00%> (-0.03%) ⬇️
Library/ViewModels/PledgeViewModel.swift 99.74% <100.00%> (-0.01%) ⬇️
...ary/ViewModels/RewardAddOnSelectionViewModel.swift 98.12% <100.00%> (-0.02%) ⬇️
...ibrary/ViewModels/RewardsCollectionViewModel.swift 99.39% <100.00%> (-0.04%) ⬇️
Library/Navigation.swift 76.89% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a191c...cb269cc. Read the comment docs.

@singhhari singhhari merged commit 059a00a into master Feb 25, 2021
@singhhari singhhari deleted the EP-162-create-properties branch February 25, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants