[EP-225] CTA Clicked (pledge_initiate) #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding tests for CTA Clicked event and pledge_initiate context in the event properties
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
=======================================
Coverage 85.86% 85.86%
=======================================
Files 1104 1104
Lines 96140 96147 +7
=======================================
+ Hits 82550 82558 +8
+ Misses 13590 13589 -1
Continue to review full report at Codecov.
|
singhhari
suggested changes
Mar 1, 2021
* Add CTA Context test to PledgeCTAContainerViewModel
singhhari
suggested changes
Mar 2, 2021
singhhari
approved these changes
Mar 3, 2021
Library/Tracking/KSRAnalytics.swift
Outdated
| @@ -764,9 +763,10 @@ public final class KSRAnalytics { | |||
| case .pledge: | |||
| let allProps = props | |||
| .withAllValuesFrom(optimizelyProperties) | |||
There was a problem hiding this comment.
Ah, sorry, I missed this earlier but can you get rid of the optimizelyProperties param. It doesn't look like the new event requires this info.
There was a problem hiding this comment.
When I got rid of it, this test testTrackingEvents_Pledge() in PledgeCTAContainerViewViewModelTests fails, because it checks for those optimizelyProperties
# Conflicts: # Library/Tracking/KSRAnalytics.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
"Project Page Pledge Button Clicked" event is updated to CTA Clicked with pledge_initiate context
馃 Why
Convert DataLake event to Segment event