[EP-230] Page Viewed (project) #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgsamudio
approved these changes
Mar 2, 2021
| case updates | ||
|
|
||
| var trackingString: String { | ||
| switch self { | ||
| case .campaign: return "campaign" | ||
| case .comments: return "comments" | ||
| case .faq: return "faq" |
There was a problem hiding this comment.
I guess we aren't using this in the app
There was a problem hiding this comment.
Correct. These are tabs in the webview and will likely be handled. by web.
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
==========================================
- Coverage 85.86% 85.86% -0.01%
==========================================
Files 1104 1104
Lines 96163 96140 -23
==========================================
- Hits 82573 82551 -22
+ Misses 13590 13589 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Updating the event that is called when a
Projectis viewed on native iOS. In addition, we are including functionality that will trigger an event when the Campaign, Updates or Comments associated with a given project, are viewed.🤔 Why
Continuing to extend our Segment implementation and flesh out our new analytics client.