Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-231] Page Viewed (rewards) #1388

Merged
merged 4 commits into from
Mar 5, 2021
Merged

Conversation

singhhari
Copy link
Contributor

馃摬 What

Adding a new Page Viewed event that fires when the Rewards Carousel is opened.

馃 Why

This PR is part of our continuing efforts to move away from our legacy analytics platform and toward a full Segment implementation.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #1388 (661dc92) into master (1b985db) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
+ Coverage   85.88%   85.90%   +0.01%     
==========================================
  Files        1104     1104              
  Lines       96274    96381     +107     
==========================================
+ Hits        82686    82794     +108     
+ Misses      13588    13587       -1     
Impacted Files Coverage 螖
Library/Tracking/KSRAnalytics.swift 82.57% <100.00%> (+0.21%) 猬嗭笍
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (酶)
...ibrary/ViewModels/RewardsCollectionViewModel.swift 99.51% <100.00%> (+0.07%) 猬嗭笍
...y/ViewModels/RewardsCollectionViewModelTests.swift 100.00% <100.00%> (酶)
Library/Navigation.swift 77.25% <0.00%> (+0.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1b985db...661dc92. Read the comment docs.

@singhhari singhhari merged commit 06ee8ad into master Mar 5, 2021
@singhhari singhhari deleted the EP-231-page-viewed-rewards branch March 5, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants