Possible fix for setViewController crash #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing a number of crashes with the following message:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: [views count] == 3'
Pretty much all searches for this type of crash suggest that the call to
UIPageViewController
setViewControllers(_:direction:animated:completion:)
is not happening on the main thread.Example: http://stackoverflow.com/questions/24000712/pageviewcontroller-setviewcontrollers-crashes-with-invalid-parameter-not-satisf
I've not been able to reproduce this but according to Hockey it seems to be happening frequently enough on app startup for it to be something we'd want to solve.
I added a symbolic breakpoint to trace the first call to
-[UIPageViewController setViewControllers:direction:animated:completion:]
at startup and it appears to be this one so suggestion is that we try wrapping it inDispatch.main.async
to see if it alleviates the issue on Hockey.It's worth pointing out that we've had some strange successes with this before 馃