[EP-245] CTA Clicked (watch_project) #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhhari
suggested changes
Mar 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #1391 +/- ##
==========================================
+ Coverage 85.94% 85.95% +0.01%
==========================================
Files 1104 1104
Lines 96669 96751 +82
==========================================
+ Hits 83082 83163 +81
- Misses 13587 13588 +1
Continue to review full report at Codecov.
|
singhhari
suggested changes
Mar 11, 2021
Library/Tracking/KSRAnalytics.swift
Outdated
| @@ -1203,21 +1202,27 @@ public final class KSRAnalytics { | |||
| - parameter project: The project being watched | |||
| - parameter location: The location context of where the project is being watched from | |||
| - parameter params: The optional Discover params if the project is being watched from Discover | |||
| - parameter watchContext: The context of the watch/saved project | |||
There was a problem hiding this comment.
update parameter name and description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
CTA Clicked (watch_project)
馃 Why
Segment Integration
馃洜 How
More in-depth discussion of the change or implementation.
WatchContexttrackWatchProjectButtonClicked(watchContext). This allows tracking for watch and unwatch project.unwatchcontext.