[NT-1809] Re-factoring add on selection + shipping rules logic #1399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Because we make use of both
shippingRules
andshippingRulesExpanded
there is some slightly confusing logic related to add on selection. In particular, we useshippingRules
before add on selection and theexpanded
variant after. This led to a bug related to digital only add ons not rendering bc of a mishandled edge case. This PR simplifies the way we handle this flow and effectively uses shippingRule up until a particular add on is being mapped/filtered.🤔 Why
Fixing a bug where a project with digital only add ons is returning no value for shipping rules and leading to a condition that looks like the UI timing out on a network request.