Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-256] Card Clicked #1400

Merged
merged 8 commits into from
Mar 19, 2021
Merged

[EP-256] Card Clicked #1400

merged 8 commits into from
Mar 19, 2021

Conversation

singhhari
Copy link
Contributor

📲 What

Updating existing Editorial Page Header Clicked and Project Card Clicked events to Card Clicked. Also adding this event into some new places like our ThanksViewModel, SearchViewModel and within the backed/saved Profile tab.

🤔 Why

Segment phase two

@nativeksr
Copy link
Collaborator

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #1400 (0f9caa8) into master (d7228be) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1400      +/-   ##
==========================================
+ Coverage   85.99%   86.03%   +0.03%     
==========================================
  Files        1104     1104              
  Lines       97025    97243     +218     
==========================================
+ Hits        83441    83659     +218     
  Misses      13584    13584              
Impacted Files Coverage Δ
Library/ViewModels/FeatureFlagToolsViewModel.swift 100.00% <ø> (ø)
...ry/ViewModels/FeatureFlagToolsViewModelTests.swift 100.00% <ø> (ø)
Library/Tracking/KSRAnalytics.swift 83.73% <100.00%> (+0.31%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ø)
Library/ViewModels/ActivitiesViewModel.swift 98.30% <100.00%> (+0.04%) ⬆️
Library/ViewModels/ActivitiesViewModelTests.swift 100.00% <100.00%> (ø)
.../ViewModels/BackerDashboardProjectsViewModel.swift 92.23% <100.00%> (+1.02%) ⬆️
...Models/BackerDashboardProjectsViewModelTests.swift 100.00% <100.00%> (ø)
Library/ViewModels/DiscoveryPageViewModel.swift 96.80% <100.00%> (-0.04%) ⬇️
...brary/ViewModels/DiscoveryPageViewModelTests.swift 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7228be...0f9caa8. Read the comment docs.

Copy link
Contributor

@moderateepheezy moderateepheezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account_menu does not have a test in testLocationContextTrackingStrings. However, you can skip that because I as-well defined account_menu in my branch, and include the tests for it. It's going to cause conflict on my branch, but that I can resolve.

@singhhari
Copy link
Contributor Author

singhhari commented Mar 19, 2021

account_menu does not have a test in testLocationContextTrackingStrings. However, you can skip that because I as-well defined account_menu in my branch, and include the tests for it. It's going to cause conflict on my branch, but that I can resolve.

Updated and added a few more checks for it elsewhere.

@singhhari singhhari merged commit 48f5f80 into master Mar 19, 2021
@singhhari singhhari deleted the EP-256-card-clicked branch March 19, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants