[EP-319] Page Viewed (change_payment) #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
=======================================
Coverage 86.10% 86.11%
=======================================
Files 1104 1104
Lines 97874 97908 +34
=======================================
+ Hits 84278 84312 +34
Misses 13596 13596
Continue to review full report at Codecov.
|
| @@ -734,22 +734,21 @@ final class KSRAnalyticsTests: TestCase { | |||
| self.assertProjectProperties(segmentClient.properties.last) | |||
| } | |||
|
|
|||
| func testTrackCheckoutPaymentMethodViewed() { | |||
| func testTrackCheckoutPaymentMethodViewed_PledgeViewContext_Pledge() { | |||
There was a problem hiding this comment.
So there's a similar test inside testContextLocationProperties(), maybe we delete them in favour on the methods you created?
There was a problem hiding this comment.
Ah I see. Pushed up a commit with the updates.
tobitech
approved these changes
Mar 25, 2021
moderateepheezy
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
Extending the event tracking functionality of our
PledgeViewModelto handle aPage Viewedevent specifically for when the payment method is changed.馃 Why
Phase 3 Segment implementation