Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-283] CTA Clicked (campaign details) #1409

Merged
merged 10 commits into from
Mar 29, 2021

Conversation

tobitech
Copy link
Contributor

📲 What

Send a CTA clicked event when the "Read more about the campaign" is clicked to view campaign details

🤔 Why

Part of phase 3 iOS Native events tracking

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #1409 (1f49545) into master (e5bffc2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1409   +/-   ##
=======================================
  Coverage   86.09%   86.09%           
=======================================
  Files        1104     1104           
  Lines       97806    97804    -2     
=======================================
- Hits        84206    84205    -1     
+ Misses      13600    13599    -1     
Impacted Files Coverage Δ
Library/Tracking/KSRAnalytics.swift 84.73% <100.00%> (+0.12%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ø)
.../ViewModels/ProjectPamphletMainCellViewModel.swift 98.05% <100.00%> (+0.01%) ⬆️
...Models/ProjectPamphletMainCellViewModelTests.swift 100.00% <100.00%> (ø)
Library/Navigation.swift 77.25% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5bffc2...1f49545. Read the comment docs.

* Add page context to the same event method
@singhhari singhhari self-assigned this Mar 29, 2021
Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions related to the changes but also need to bump coverage.

@tobitech tobitech requested a review from singhhari March 29, 2021 17:08
Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tobitech tobitech merged commit 7e43a1d into master Mar 29, 2021
@tobitech tobitech deleted the EP-283-cta-clicked-campaign-details branch March 29, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants