Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-400] QA Phase 1 Add properties #1411

Merged
merged 8 commits into from
Mar 30, 2021
Merged

Conversation

tobitech
Copy link
Contributor

📲 What

Add some new properties to User, Session and Project property groups

🤔 Why

Event Project Phase 1 QA additions

…erty groups

* Create a helper for testing user properties with a template user.

* Add a check for repeat creator status in project properties
* Provide default value for isRepeatCreator property of project's creator
# Conflicts:
#	Library/Tracking/KSRAnalyticsTests.swift
@tobitech tobitech changed the title [EP-400] QA Phase1 Add properties [EP-400] QA Phase 1 Add properties Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #1411 (b41f019) into master (967d16a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1411   +/-   ##
=======================================
  Coverage   86.09%   86.10%           
=======================================
  Files        1106     1106           
  Lines       97830    97849   +19     
=======================================
+ Hits        84230    84249   +19     
  Misses      13600    13600           
Impacted Files Coverage Δ
Library/Tracking/KSRAnalytics.swift 84.79% <100.00%> (+0.05%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967d16a...b41f019. Read the comment docs.

@singhhari singhhari self-assigned this Mar 29, 2021
Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing checkout_reward_has_items?

KsApi/models/templates/ProjectTemplates.swift Show resolved Hide resolved
Library/Tracking/KSRAnalyticsTests.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tobitech tobitech merged commit 3c6cc3c into master Mar 30, 2021
@tobitech tobitech deleted the EP-400-qa-phase1-add-properties branch March 30, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants