-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-400] QA Phase 1 Add properties #1411
Conversation
…erty groups * Create a helper for testing user properties with a template user. * Add a check for repeat creator status in project properties
* Provide default value for isRepeatCreator property of project's creator
# Conflicts: # Library/Tracking/KSRAnalyticsTests.swift
Codecov Report
@@ Coverage Diff @@
## master #1411 +/- ##
=======================================
Coverage 86.09% 86.10%
=======================================
Files 1106 1106
Lines 97830 97849 +19
=======================================
+ Hits 84230 84249 +19
Misses 13600 13600
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing checkout_reward_has_items
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
📲 What
Add some new properties to User, Session and Project property groups
🤔 Why
Event Project Phase 1 QA additions