[EP-439] QA Phase 2 - Properties to remove #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
- Coverage 86.11% 86.10% -0.01%
==========================================
Files 1106 1106
Lines 97950 97922 -28
==========================================
- Hits 84347 84319 -28
Misses 13603 13603
Continue to review full report at Codecov.
|
tobitech
approved these changes
Apr 5, 2021
singhhari
suggested changes
Apr 6, 2021
| props["device_orientation"] = self.deviceOrientation | ||
| props["device_distinct_id"] = self.distinctId |
There was a problem hiding this comment.
Doesn't look like we are using distinctId for anything else in the file. I would delete this and double check everything is compiling fine.
There was a problem hiding this comment.
Thanks, I missed that.
| @@ -1503,10 +1503,7 @@ public final class KSRAnalytics { | |||
| props["country"] = self.config?.countryCode | |||
| props["display_language"] = AppEnvironment.current.language.rawValue | |||
| props["device_type"] = self.device.deviceType | |||
| props["device_manufacturer"] = "Apple" | |||
| props["device_model"] = KSRAnalytics.deviceModel | |||
There was a problem hiding this comment.
Doesn't look like we are using deviceModel for anything else in the file. I would delete this and double check everything is compiling fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Remove the following properties from segment.
🤔 Why
Based on feedback from QA on Phase 2 tickets, some Segment event properties aren't needed.