Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-427] CTA-Clicked (project) #1435

Merged
merged 7 commits into from
Apr 19, 2021
Merged

Conversation

moderateepheezy
Copy link
Contributor

@moderateepheezy moderateepheezy commented Apr 19, 2021

📲 What

  1. Update event properties we send to segment when tracking projects clicked from the result of a search query. The event should send the following properties specifically.
    events = "CTA Clicked"
    context_cta = project
    context_page = search
    context_location = search_results
    context_type = results

  2. Change the event name of trackProjectCardClicked to ctaClicked from cardClicked

  3. Update event name for tests using trackProjectCardClicked to use ctaClicked

🤔 Why

Projects clicked from the list of projects from a search query are sending generic events properties applicable to all project card clicked. Some of the events properties should be different when the projects are clicked from a search query.

👀 See

Screenshot 2021-04-19 at 19 27 52

✅ Acceptance criteria

  1. Click on the search tab
  2. Click on search bar and type in some keyword
  3. From the list of results, click on a project card
  4. verify the following events are being sent to segment only when user clicks on projects from search results

events = "CTA Clicked"
context_cta = project
context_page = search
context_location = search_results
context_type = results

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #1435 (ca833ab) into master (6b8d6b4) will increase coverage by 3.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
+ Coverage   86.09%   89.47%   +3.38%     
==========================================
  Files        1108      739     -369     
  Lines       98556    68686   -29870     
==========================================
- Hits        84849    61456   -23393     
+ Misses      13707     7230    -6477     
Impacted Files Coverage Δ
Library/Tracking/KSRAnalytics.swift 85.57% <100.00%> (+0.06%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ø)
Library/ViewModels/ActivitiesViewModel.swift 98.31% <100.00%> (+<0.01%) ⬆️
Library/ViewModels/ActivitiesViewModelTests.swift 100.00% <100.00%> (ø)
.../ViewModels/BackerDashboardProjectsViewModel.swift 92.30% <100.00%> (+0.07%) ⬆️
...Models/BackerDashboardProjectsViewModelTests.swift 100.00% <100.00%> (ø)
Library/ViewModels/DiscoveryPageViewModel.swift 96.77% <100.00%> (+<0.01%) ⬆️
...brary/ViewModels/DiscoveryPageViewModelTests.swift 100.00% <100.00%> (ø)
Library/ViewModels/SearchViewModel.swift 100.00% <100.00%> (ø)
Library/ViewModels/SearchViewModelTests.swift 100.00% <100.00%> (ø)
... and 375 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8d6b4...ca833ab. Read the comment docs.

@singhhari singhhari self-assigned this Apr 19, 2021
Library/Tracking/KSRAnalytics.swift Outdated Show resolved Hide resolved
Library/Tracking/KSRAnalyticsTests.swift Show resolved Hide resolved
Library/Tracking/KSRAnalytics.swift Show resolved Hide resolved
Library/ViewModels/SearchViewModelTests.swift Show resolved Hide resolved
@singhhari singhhari self-requested a review April 19, 2021 21:45
Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@moderateepheezy moderateepheezy merged commit a94be5d into master Apr 19, 2021
@moderateepheezy moderateepheezy deleted the EP-427-cta-clicked-project branch April 19, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants