-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-427] CTA-Clicked (project) #1435
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
==========================================
+ Coverage 86.09% 89.47% +3.38%
==========================================
Files 1108 739 -369
Lines 98556 68686 -29870
==========================================
- Hits 84849 61456 -23393
+ Misses 13707 7230 -6477
Continue to review full report at Codecov.
|
…t clicked events
…ta-clicked-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
📲 What
Update event properties we send to segment when tracking projects clicked from the result of a search query. The event should send the following properties specifically.
events
= "CTA Clicked"context_cta
=project
context_page
=search
context_location
=search_results
context_type
=results
Change the event name of
trackProjectCardClicked
toctaClicked
fromcardClicked
Update event name for tests using
trackProjectCardClicked
to usectaClicked
🤔 Why
Projects clicked from the list of projects from a search query are sending generic events properties applicable to all project card clicked. Some of the events properties should be different when the projects are clicked from a search query.
👀 See
✅ Acceptance criteria