Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1864] Set All Codesigning To Manual #1444

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Conversation

justinswart
Copy link
Contributor

📲 What

Sets our Debug configuration to use manual code signing.

Note: Once this has merged and you've pulled the latest changes, run bundle exec fastlane match_all locally. If you see a warning in Xcode about the provisioning profile not including a signing certificate, open your Keychain Access, locate the certificate by its ID and remove it.

🤔 Why

We've always kept these set to manual to simplify code signing on our team. It's ok to set this to automatic when one needs to build the app on device but we prefer to not commit these changes to the codebase. The main reason is because our CI relies on these settings being manual but we've also found that it is less likely to lead to unexpected behavior between different folks working on the codebase.

🛠 How

Set our Debug configuration's code signing to manual.

👀 See

Before 🐛 After 🦋
image image

✅ Acceptance criteria

  • No build issues on simulator or device (set to automatic again when building to device, don't commit change).

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #1444 (637c8b7) into master (2d2598d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1444   +/-   ##
=======================================
  Coverage   86.10%   86.10%           
=======================================
  Files        1107     1107           
  Lines       98707    98707           
=======================================
  Hits        84992    84992           
  Misses      13715    13715           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2598d...637c8b7. Read the comment docs.

Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justinswart justinswart merged commit 21c02d9 into master Apr 23, 2021
@justinswart justinswart deleted the NT-1864-revert-codesigning branch April 23, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants