-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-238] CTA Clicked (discover_filter) #1447
Conversation
…pdate-conversion-rates
…er/ios-oss into EP-501-update-conversion-rates
…pdate-conversion-rates
… of a selected category filter
…ta-clicked-discovery-filter
Codecov Report
@@ Coverage Diff @@
## master #1447 +/- ##
=======================================
Coverage 86.10% 86.11%
=======================================
Files 1107 1107
Lines 98727 98753 +26
=======================================
+ Hits 85013 85038 +25
- Misses 13714 13715 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
📲 What
Update
discovery_category_name
event property to be the name of the category if theparent
field in DiscoveryParam of a selected filter is nil🤔 Why
When selecting a category_name filter (e.g. Crafts as the category and then no subcategory selected, just "All Crafts Projects") from the discover overlay on the iOS app, this is what should be sent:
context_cta = discover_filter
CORRECTcontext_location = discover_overlay
CORRECTcontext_type = category_name
CORRECTdiscover_category_name = Crafts
<<< MISSINGdiscover_subcategory_name
= Crafts CORRECTThe issue is only when the user selects a category, but does not select a subcategory. In that situation, the property discover_category_name is missing.
👀 See
✅ Acceptance criteria
All Craft
Category