Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-238] CTA Clicked (discover_filter) #1447

Merged
merged 24 commits into from
Apr 26, 2021

Conversation

moderateepheezy
Copy link
Contributor

@moderateepheezy moderateepheezy commented Apr 26, 2021

📲 What

Update discovery_category_name event property to be the name of the category if the parent field in DiscoveryParam of a selected filter is nil

🤔 Why

When selecting a category_name filter (e.g. Crafts as the category and then no subcategory selected, just "All Crafts Projects") from the discover overlay on the iOS app, this is what should be sent:

context_cta = discover_filter CORRECT

context_location = discover_overlay CORRECT

context_type = category_name CORRECT

discover_category_name = Crafts <<< MISSING

discover_subcategory_name = Crafts CORRECT

The issue is only when the user selects a category, but does not select a subcategory. In that situation, the property discover_category_name is missing.

👀 See

Screenshot 2021-04-26 at 16 25 28

✅ Acceptance criteria

  1. Select a Category in drop down menu on Discovery Tab. e.g Craft
  2. Select All Craft Category
  3. Verify on segment that

discover_category_name = "Craft"
discover_subcategory_name = "Craft"

moderateepheezy and others added 21 commits April 21, 2021 17:42
…er/ios-oss into EP-501-update-conversion-rates
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1447 (d5f142e) into master (7a7d0a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1447   +/-   ##
=======================================
  Coverage   86.10%   86.11%           
=======================================
  Files        1107     1107           
  Lines       98727    98753   +26     
=======================================
+ Hits        85013    85038   +25     
- Misses      13714    13715    +1     
Impacted Files Coverage Δ
Library/Tracking/KSRAnalytics.swift 85.46% <100.00%> (+0.01%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ø)
Library/Navigation.swift 76.89% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7d0a6...d5f142e. Read the comment docs.

@singhhari singhhari changed the title [EP-23] CTA Clicked (discover_filter) [EP-238] CTA Clicked (discover_filter) Apr 26, 2021
Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@moderateepheezy moderateepheezy merged commit ec633fa into master Apr 26, 2021
@moderateepheezy moderateepheezy deleted the EP-238-cta-clicked-discovery-filter branch April 26, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants