Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-334] Page Viewed (sign_up) #1448

Merged
merged 2 commits into from
Apr 26, 2021
Merged

[EP-334] Page Viewed (sign_up) #1448

merged 2 commits into from
Apr 26, 2021

Conversation

singhhari
Copy link
Contributor

πŸ“² What

Adding a new Page Viewed event with a context_page property of sign_up in the SignUpViewModel.

πŸ€” Why

This is part of our ongoing implementation of Segment on the native apps.

πŸ‘€ See

Screen Shot 2021-04-26 at 1 06 07 PM

βœ… Acceptance criteria

  • Navigate to the SignUpViewController
  • Verify in the Segment debugger that a Page Viewed event was fired with a context_page property of sign_up.

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1448 (25b48f2) into master (ec633fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1448   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files        1107     1107           
  Lines       98753    98777   +24     
=======================================
+ Hits        85039    85063   +24     
  Misses      13714    13714           
Impacted Files Coverage Ξ”
Library/Tracking/KSRAnalytics.swift 85.51% <100.00%> (+0.05%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ΓΈ)
Library/ViewModels/SignupViewModel.swift 97.72% <100.00%> (+0.08%) ⬆️
Library/ViewModels/SignupViewModelTests.swift 100.00% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update ec633fa...25b48f2. Read the comment docs.

@singhhari singhhari merged commit 7c51c6e into master Apr 26, 2021
@singhhari singhhari deleted the EP-334-page-viewed-sign-up branch April 26, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants