-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-450] context_page = other #1449
Conversation
page
field from track
function…ontext_page_other
Codecov Report
@@ Coverage Diff @@
## master #1449 +/- ##
=======================================
Coverage 86.11% 86.12%
=======================================
Files 1107 1107
Lines 98798 98811 +13
=======================================
+ Hits 85084 85097 +13
Misses 13714 13714
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
📲 What
page
parameter intrack
function inside KSRAnalytics.page
incontextProperties()
function toother
for some events that Product/Insight hasn't definedpage_context
for.🤔 Why
We previously had
page
as a parameter in ourtrack
function as well ascontextProperties()
function. This is not necessary as we need all of ourContext Properties
to be in on function calledcontextProperties()