Handle live video being disabled during stream #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
commented
May 3, 2017
| extension LiveVideoViewController: OTSubscriberDelegate { | ||
| public func subscriberDidConnect(toStream subscriber: OTSubscriberKit) {} | ||
|
|
||
| public func subscriber(_ subscriber: OTSubscriberKit, didFailWithError error: OTError) {} |
There was a problem hiding this comment.
This needs to be implemented for protocol conformance but we've not cared about this error'ing yet. I want to consider its effect and implement it in a separate PR.
| @@ -93,6 +93,7 @@ public final class LiveStreamContainerViewController: UIViewController { | |||
| _ = self.loaderLabel | |||
| |> UILabel.lens.font .~ .ksr_headline(size: 14) | |||
| |> UILabel.lens.textColor .~ .white | |||
| |> UILabel.lens.textAlignment .~ .center | |||
There was a problem hiding this comment.
This caused almost all the snapshots for this view controller to have to be re-recorded 😐
|
|
mbrandonw
approved these changes
May 3, 2017
| @@ -10,6 +10,13 @@ private struct TestOTStreamType: OTStreamType { | |||
| fileprivate let streamId: String | |||
| } | |||
| private class TestOTErrorType: NSError, OTErrorType {} | |||
| private struct TestOTSubscriberVideoEventReasonType: OTSubscriberVideoEventReasonType { | |||
There was a problem hiding this comment.
don't think we need to suffix this with Type since it's a concrete implementation
There was a problem hiding this comment.
ah right, lemme tidy that up
| self.showErrorAlert | ||
| ) | ||
| self.showErrorAlert, | ||
| videoEnabled.filter { !$0 }.mapConst(localizedString( |
There was a problem hiding this comment.
could filter(isFalse) if you wanted to point-free.
There was a problem hiding this comment.
of course! thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing of live chat a bug was logged that the video freezed up but that audio and chat continued. I did some testing on a not-so-great 3G connection and was able to reproduce this.
It seems that OpenTok's
OTSubscriberDelegate(which we hadn't previously implemented) sendssubscriberVideoDisabledandsubscriberVideoEnabledwith areasonargument which in this case isqualityChanged.I've changed our
LiveVideoPlaybackState.playingstate to have an associatedBoolvalue ofvideoEnabledso that we can handle this.If OpenTok disables the video we hide the view and display text indicating that video will resume when the connection improves. Although I didn't see it resume during my testing, OpenTok does say that the video may resume.