Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-491] QA CTA Clicked Search #1450

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Conversation

moderateepheezy
Copy link
Contributor

πŸ“² What

Add context_page = other when user clicks on Search Tab from Creator Dashboard Tab

πŸ€” Why

This is a continuation of our Segment Integration.

πŸ‘€ See

Screenshot 2021-04-27 at 23 15 29

βœ… Acceptance criteria

  • Navigate to Creator's Dashboard Tab
  • Switch to Search Tab
  • Verify on Segment debugger that

context_page = other
context_cta = search
context_location = global_nav

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #1450 (b87b554) into master (aa501b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1450   +/-   ##
=======================================
  Coverage   86.11%   86.12%           
=======================================
  Files        1107     1107           
  Lines       98811    98828   +17     
=======================================
+ Hits        85096    85114   +18     
+ Misses      13715    13714    -1     
Impacted Files Coverage Ξ”
Library/Tracking/KSRAnalytics.swift 85.85% <100.00%> (+0.03%) ⬆️
Library/Tracking/KSRAnalyticsTests.swift 100.00% <100.00%> (ΓΈ)
Library/Navigation.swift 77.25% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update aa501b2...b87b554. Read the comment docs.

Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@moderateepheezy moderateepheezy merged commit ec3565f into master Apr 28, 2021
@moderateepheezy moderateepheezy deleted the EP-491-qa-cta-clicked-search branch April 28, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants