[NT-1890] Update Fastlane, add App Store Connect Auth #1466
Conversation
| app_identifier: ENV["ITUNES_APP_IDENTIFIER"], | ||
| app: ENV["ITUNES_APP_ID"], | ||
| ipa: "#{gym_dir}/Kickstarter.ipa", | ||
| team_name: ENV["ITUNES_TEAM_NAME"], | ||
| skip_screenshots: true, | ||
| skip_metadata: true | ||
| skip_metadata: true, | ||
| precheck_include_in_app_purchases: false |
There was a problem hiding this comment.
App Store Connect Auth does not support this during precheck so I've just disabled it for now (we don't have in-app purchases π€·ββοΈ)
| @@ -3,7 +3,7 @@ git_url("https://github.com/kickstarter/ios-certificates") | |||
| type("development") # The default type, can be: appstore, adhoc, enterprise or development | |||
|
|
|||
| # app_identifier(["tools.fastlane.app", "tools.fastlane.app2"]) | |||
| # username("user@fastlane.tools") # Your Apple Developer Portal username | |||
| username("native-ci@kickstarter.com") # Your Apple Developer Portal username | |||
There was a problem hiding this comment.
Updated this while I was in here so that we don't have to type this in every time we run match.
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
==========================================
- Coverage 86.15% 84.98% -1.18%
==========================================
Files 1109 1109
Lines 99144 99144
Branches 0 27885 +27885
==========================================
- Hits 85417 84254 -1163
- Misses 13727 13960 +233
- Partials 0 930 +930
Continue to review full report at Codecov.
|
|
@justinswart do you know why the test coverage dropped so much? |
| @@ -128,13 +128,14 @@ platform :ios do | |||
| lane :itunes_deliver do | |||
| deliver( | |||
| force: true, | |||
| username: ENV["ITUNES_CONNECT_ACCOUNT"], | |||
| api_key_path: "./Frameworks/native-secrets/ios/app-store-connnect-auth.json", | |||
There was a problem hiding this comment.
Just curious mostly, does this api_key_path reference another git repo from within itself? Assuming ./Frameworks is a prebuilt binary that gets updated once we run the make secrets command? And it references the remote repo for native-secrets, which is why we need to create the app_store_connect_auth.json there?
There was a problem hiding this comment.
Yeah good question - so we have this private native-secrets repo which just contains stuff that we don't want directly exposed in the open source repo. It's not a framework really, we just clone the repo to that directory. This just ensures that when the open source repo is cloned that those sensitive details aren't exposed along with it.
@jgsamudio I think just some issue with codecov, perhaps it didn't upload its report, these changes wouldn't have affected the actual coverage. I'll try run it again. |
π² What
Updates Fastlane and adds App Store Connect API Auth.
π€ Why
Our recent uploads started failing using the app-specific password and it seemed like time to just add this authentication method.
π How
deliver.π See
https://docs.fastlane.tools/app-store-connect-api/
β Acceptance criteria