Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ApplePay crash #166

Merged
merged 1 commit into from
May 24, 2017
Merged

Fix ApplePay crash #166

merged 1 commit into from
May 24, 2017

Conversation

mbrandonw
Copy link
Contributor

There is a crash that is affecting a small number of users where if you first choose not to do Apple Pay in the reward pledge screen, but then later decide to use Apple Pay from the credit card page, you will get a crash once you drill down to the thanks screen. This is happening because the checkout view is removed from the navigation stack, and that is where the pay sheet had been presented from, and something deep in the bowels of UIKit doesn't like that :/

Turns out though, we totally don't need to be messing with the nav stack during this flow. Let's just push the thanks screen onto the stack. We already hide the back button on that screen anyway...

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! at least no Dispatch.main.async necessary 😄

@mbrandonw mbrandonw merged commit a16c118 into master May 24, 2017
@mbrandonw mbrandonw deleted the ap-fix branch May 24, 2017 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants