NTV-1435 - Migrate Shipping V1 to GQL #1691
Conversation
|
|
||
| return nil | ||
| } | ||
| if project.state == .live, |
There was a problem hiding this comment.
does this mean this info is hidden when the project is not live?
There was a problem hiding this comment.
Hey Bessie, yes, the project needs to be in live state to show the shipping labels.
For all the base reward cards, (add-ons are only shown if project is live) we show 2 strings when the project isn't live (backer count and has add-ons) and two more if the project is live (shipping and time left).
Confirmed its the same on Android for non-live projects.
Codecov Report
@@ Coverage Diff @@
## feature/local-pickup-rewards #1691 +/- ##
=============================================================
Coverage 85.45% 85.45%
=============================================================
Files 1255 1255
Lines 111499 111514 +15
Branches 29665 29659 -6
=============================================================
+ Hits 95281 95295 +14
- Misses 15177 15179 +2
+ Partials 1041 1040 -1
Continue to review full report at Codecov.
|
|
Hope its cool if I merged this before you finished the review @iambchan . If you have further questions I can reopen this pr. |
* NTV-1435 - Migrate Shipping V1 to GQL (#1691) * [NTV-1446] Reward and Addon Cards Display Shipping Location (#1693) * [NTV-1522] Pledge Screen Local Reward Pickup UI (#1695) * [NTV-1690] Reward Card Shipping Preference Check + Other Cleanup (#1696) * fixed layout issue occuring on estimated delivery date and reward location stackview in manage pledge page. * updated tests for previous tests on reward location view to include check for shipping preference. * [PAY-1442] Available Add Ons And Shipping Costs When Local Reward Selected (#1697) * [PAY-1525] Local Pickup Optimizely Feature Flag (#1698) * added local pickup optimizely flag and tests * added filtering logic to reward selection view controller based on ff for local pickup. * corrected existing tests * added tests for allowable rewards on reward collection view controller and view model. * corrected an issue where if reward was not allowed to be displayed the next reward would by default not be shown. * quick test build correction in Library
π² What
Fix the missing shipping badges. Slack Thread.
"Shipping Worldwide"
"Limited Shipping"
"Only {country}"
These badges have been missing since we migrated our project model to gql. Also is connected to the data/UX for updating local receipt information.
π€ Why
This investigation was needed to understand the logic between the shipping data in the reward card and the badge related to shipping. ui/ux
Also all the places where shipping address selector, shipping label got its data. Will hopefully help with QA all possible scenarios when feature complete.
π How
gql logic for returning shipping summary information.
If the reward isn't local, above logic states shipping summary can be used to display the badge data for shipping labels. This replaces the v1
shipping_typepreviously used.Left the
shipping_typein the existing v1 model because it causes crashes when v1'sdiscoverendpoint is called (app launch). Didn't do a deep dive but there are still use cases forRewardmodelshippingtypefield.Anyway, the logic above also clarifies that if the reward has
localReceiptLocationthen the badge for shipping data should be hidden, and insteadshippingsummaryis used for theReward Locationfield.π See
Before π
After π¦
β Acceptance criteria
β° TODO