[Beta Build] Merging Feature/Payment-Sheet into Main #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed carthage dependency of stripe sdk. Moved to SPM. Going from version 18 to 22. Not building, and no code changes. Will commit individual working frameworks once they are compiling. * wrapped changes to add new card view. * all frameworks building. Documented changes in PR. Haven't run tests yet, they might fail on Kickstarter-iOS framework. * updated tests for STPPaymentHandler * wrapped STPPaymentCardTextField in our own class so Settings.storyboard isn't dependant on Stripe directly. * wrapped STPPaymentCardTextField in our own class so Settings.storyboard isn't dependant on Stripe directly. * added class that wraps the STPPaymentCardTextField, cleaned up depedencies on Kickstarter-Framework and tests. * updated publishable key in add new card view controller * updated publishable key in add new card view controller * removed duplicate zip code from add new card view.
* added setup intent and mutation with tests. Still missing service layer request, envelope and tests for those. * service call, adapter, stubs, tests. * updated graph schema and create setup intent input.
…eet (#1707) * added logic to pass the new payment sheet data to the data source and cell. Everything is in place to work for one payment sheet card. The only thing missing is the hook into the reloadPaymentMethods signal after the payment option is updated with card data. Also needs testing. * adding a new payment sheet card displays in within the payment methods view. Need to correct for multiple cards added and selecting cards. * allowed adding multiple cards via payment sheet. Still need to allow card selection and write tests. * added tests for data source and pledge payment methods view model. No view controller tests, cell tests or view model tests. Need to add those separately, because require the Stripe library to work within the testing framework, which it should if using @testable.
* optimizely ff added and tested. Needs to be added to existing pledge payment methods page. * added and tested in-app gating within pledge page. Still need unit tests and the ability to not see the ff in production environment for now (because there is untested scenario where user can select a payment method after adding a new payment sheet card. Not sure if this should be allowed in production atm.) * revised logic around checking the ff helper function and updating the go to add new card signals. Unit tested logic changes.)
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
- Coverage 85.55% 85.23% -0.32%
==========================================
Files 1258 1269 +11
Lines 112741 113329 +588
Branches 29904 30068 +164
==========================================
+ Hits 96452 96598 +146
- Misses 15242 15684 +442
Partials 1047 1047
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a beta build out for features that are not complete but testable and to allow tickets to be moved into "Done" before final code reaches production, we're going to merge feature branches against
mainregularly.All this code is in a releasable state.
Meaning: if we cut a production build after merging this branch, no untested/incomplete code is available to users because it has been gated by Optimizely feature flags.