[PAY-1829] Card Selection With Newly Created Payment Sheet Cards #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etup intent methods will update existing signals in pledge payment methods view and pledge view.
|
@scottkicks Hey Scott, just getting the hang of adding you to new PR's -- no need to review it or anything, feel free to post questions/comments if you want. |
Generated by 🚫 Danger |
msadoon
commented
Aug 11, 2022
| @@ -8,6 +8,7 @@ public struct CreateBackingInput: GraphMutationInput, Encodable { | |||
| let projectId: String | |||
| let refParam: String? | |||
| let rewardIds: [String] | |||
| let setupIntentClientSecret: String? | |||
There was a problem hiding this comment.
Useful in the next ticket.
Codecov Report
@@ Coverage Diff @@
## main #1711 +/- ##
==========================================
+ Coverage 85.23% 85.26% +0.03%
==========================================
Files 1269 1269
Lines 113329 113813 +484
Branches 30068 30143 +75
==========================================
+ Hits 96598 97046 +448
- Misses 15684 15721 +37
+ Partials 1047 1046 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
This PR address the selection logic of picking a card after it has been added via the new payment sheet.
🤔 Why
User should see newly added card for project with/without backing pre-selected. User should also be able to pick between pre-existing cards and newly created ones. (Both with the payment sheet and no).
🛠 How
configuredCardsis updated with new setup intent card datanewSetupIntentCardsafter the flow controller has returned the display data (it's coupled with the setup intent for that display data only.)updatedCardsis now based onconfiguredCardsinstead ofcards, after its' been combined withnewSetupIntentCards. PreviouslyupdatedCardswas used withdidSelectRowAtwhich is the same as now, except the setup intent card data is combined in here as well.Previous flow:
cards= user's fetched cards + new cards added through add new card pageconfiguredCards=cards(after some card selection logic)configuredCards-->reloadPaymentMethodsupdatedCards=didSelectRowAt+cardsupdatedCards-->reloadPaymentMethodsNew flow:
cards= user's fetched cards + new cards added through add new card pageconfiguredCards=cards(after some card selection logic)setupIntentConfiguredCards=configuredCardsOR (inclusive)newSetupIntentCards(re-select correct card if setup intent cards added)setupIntentConfiguredCards-->reloadPaymentMethodsupdatedCards=setupIntentConfiguredCardsOR (inclusive)configuredCardsupdatedCards+didSelectRowAt(re-select cards if setup intent cards were added) -->reloadPaymentMethodsWhenever setup intent card logic is combined with pre-existing
cards, we re-configure the pledge display data for either one or the other card type display, because they are two different models.Also the payment source id OR the setup intent is passed to the pledge view for making the backing.
👀 See
Trello, screenshots, external resources?
After 🐛
Simulator.Screen.Recording.-.iPhone.8.-.2022-08-11.at.15.33.51.mp4
Before 🦋
Simulator.Screen.Recording.-.iPhone.8.-.2022-08-11.at.15.38.31.mp4
✅ Acceptance criteria
With
ios_payment_sheetON.pledgecontextWith
ios_payment_sheetOFF.pledgecontext⏰ TODO
CreateBackingDatatoPledgeViewModelin this ticket, as that is more aligned with the creation of the backing in the next ticket.