New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAY-1816] Payment Sheet Loading States #1713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting progress screen is. Still need to eliminate duplicate clicks and ensure pledges can be made while loading. Also double check error states and test.
…y or terms and service click.
…loading is in flight.
…et for external actions.
… simpler more manageable.
… simpler more manageable.
4 tasks
…ss locally without it and were previously failing on ci.
Codecov Report
@@ Coverage Diff @@
## main #1713 +/- ##
==========================================
+ Coverage 85.32% 85.33% +0.01%
==========================================
Files 1269 1271 +2
Lines 114295 114511 +216
Branches 30195 30236 +41
==========================================
+ Hits 97518 97715 +197
- Misses 15729 15746 +17
- Partials 1048 1050 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Before and after the "New Payment Method" button is tapped we have a lag that is time taken during network requests from our end before Stripe's payment sheet is displayed.
Let's inform the user that he/she needs to wait before seeing the new UI/UX, and
🤔 Why
It's good to let the user understand there is a waiting period before we eventually update the UI/UX with the data from Stripe's payment sheet.
🛠 How
PledgePaymentMethodAddCell
gets a loading state with anActivityIndicator
.PledgePaymentMethodsDataSource
gets a state to turn on/check loading for the above cell.PledgeViewController
gets a delegate to cancel appearance of payment sheet if the user pledges/clicks TOS/presents other views. User cannot click on "Add new card" until its out of its loading state.PledgeViewModel
gets ashouldCancelPaymentSheetAppearance
signal that is triggered whenever the above delegate method is called, also internally when new cards are selected and if there is an error onPledgePaymentMethodsViewController
.👀 See
Before 🐛
Simulator.Screen.Recording.-.iPhone.8.-.2022-08-24.at.10.29.19.mp4
After 🦋
Simulator.Screen.Recording.-.iPhone.8.-.2022-08-24.at.10.21.29.mp4
✅ Acceptance criteria
⏰ TODO