[Unticketed] Updated Stripe Framework #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 1275 1275
Lines 114806 114806
Branches 30343 30343
=======================================
+ Hits 97968 97970 +2
+ Misses 15786 15784 -2
Partials 1052 1052
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msadoon
added
ready to merge
needs review
and removed
needs review
ready to merge
labels
scottkicks
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
The new Stripe framework fixes a bug where 4.7 inch screens launched in landscape do not appear unless rotated. Very minor.
🤔 Why
We would ideally like to support all orientations for all phones natively
🛠 How
Stripe upgraded their framework.
👀 See
Before 🐛
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2022-09-01.at.14.10.17.mp4
After 🦋
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2022-09-01.at.14.05.11.mp4
✅ Acceptance criteria